-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support up to Python 3.12 #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch works with Python 3.12 only. |
It's now backward compatible with older python releases |
jcapiitao
changed the title
Adjust tests for taskName attribute added in Python 3.12
Add support up to Python 3.12
Jul 18, 2023
jcapiitao
force-pushed
the
python3.12
branch
2 times, most recently
from
July 18, 2023 14:00
1c56a3b
to
77bafed
Compare
jd
previously requested changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update Mergify configuration too.
Right, it's done now 👍 |
jcapiitao
commented
Jul 18, 2023
gh-91513: Added taskName attribute to logging module for use with asyncio tasks. python/cpython#91513 [1] credits to https://github.com/hrnciar [1] python/cpython#91513
Rebased on top of the main branch |
sileht
previously approved these changes
Jul 31, 2023
sileht
reviewed
Oct 19, 2023
sileht
reviewed
Oct 19, 2023
sileht
previously approved these changes
Oct 19, 2023
sileht
approved these changes
Oct 19, 2023
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 5, 2024
https://build.opensuse.org/request/show/1144327 by user dgarcia + anag+factory - Update to 3.2.5.1: * Only CI changes. - Skip some tests that are failing with python 3.12 because of some issue in the way tests are running gh#Mergifyio/daiquiri#74
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 7, 2024
https://build.opensuse.org/request/show/1144327 by user dgarcia + anag+factory - Update to 3.2.5.1: * Only CI changes. - Skip some tests that are failing with python 3.12 because of some issue in the way tests are running gh#Mergifyio/daiquiri#74
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 7, 2024
https://build.opensuse.org/request/show/1144327 by user dgarcia + anag+factory - Update to 3.2.5.1: * Only CI changes. - Skip some tests that are failing with python 3.12 because of some issue in the way tests are running gh#Mergifyio/daiquiri#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-91513: Added taskName attribute to logging module for use with asyncio tasks.
python/cpython#91513 [1]
credits to https://github.com/hrnciar
[1] python/cpython#91513