Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support up to Python 3.12 #74

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

jcapiitao
Copy link
Contributor

gh-91513: Added taskName attribute to logging module for use with asyncio tasks.
python/cpython#91513 [1]

credits to https://github.com/hrnciar

[1] python/cpython#91513

@jcapiitao
Copy link
Contributor Author

The patch works with Python 3.12 only.

@jcapiitao
Copy link
Contributor Author

The patch works with Python 3.12 only.

It's now backward compatible with older python releases

@jcapiitao jcapiitao changed the title Adjust tests for taskName attribute added in Python 3.12 Add support up to Python 3.12 Jul 18, 2023
@jcapiitao jcapiitao marked this pull request as ready for review July 18, 2023 12:38
@jcapiitao jcapiitao force-pushed the python3.12 branch 2 times, most recently from 1c56a3b to 77bafed Compare July 18, 2023 14:00
jd
jd previously requested changes Jul 18, 2023
Copy link
Member

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update Mergify configuration too.

tox.ini Outdated Show resolved Hide resolved
@mergify mergify bot dismissed jd’s stale review July 18, 2023 14:33

Pull request has been modified.

@jcapiitao
Copy link
Contributor Author

You need to update Mergify configuration too.

Right, it's done now 👍

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@jcapiitao
Copy link
Contributor Author

Rebased on top of the main branch

sileht
sileht previously approved these changes Jul 31, 2023
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@mergify mergify bot dismissed sileht’s stale review October 19, 2023 05:18

Pull request has been modified.

tox.ini Outdated Show resolved Hide resolved
sileht
sileht previously approved these changes Oct 19, 2023
@mergify mergify bot dismissed sileht’s stale review October 19, 2023 05:22

Pull request has been modified.

@sileht sileht merged commit 8ed6232 into Mergifyio:main Oct 19, 2023
8 checks passed
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 5, 2024
https://build.opensuse.org/request/show/1144327
by user dgarcia + anag+factory
- Update to 3.2.5.1:
  * Only CI changes.
- Skip some tests that are failing with python 3.12 because of some
  issue in the way tests are running
  gh#Mergifyio/daiquiri#74
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 7, 2024
https://build.opensuse.org/request/show/1144327
by user dgarcia + anag+factory
- Update to 3.2.5.1:
  * Only CI changes.
- Skip some tests that are failing with python 3.12 because of some
  issue in the way tests are running
  gh#Mergifyio/daiquiri#74
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 7, 2024
https://build.opensuse.org/request/show/1144327
by user dgarcia + anag+factory
- Update to 3.2.5.1:
  * Only CI changes.
- Skip some tests that are failing with python 3.12 because of some
  issue in the way tests are running
  gh#Mergifyio/daiquiri#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants