#29 [Update] 에러 수정

코드 리팩토링하면서 생긴 User가 없을 때 발생하는 nullPointException 수정
MeongPanNyaengPan-MPNP · Jul 19, 2022 · c45c295 · c45c295
1 parent e6dbeec
commit c45c295
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/main/java/com/mpnp/baechelin/store/controller/StoreController.java b/src/main/java/com/mpnp/baechelin/store/controller/StoreController.java
@@ -68,6 +68,11 @@ public List<StoreCardResponseDto> getStoreInRangeHighBookmark(@RequestParam(requ
     public StoreCardResponseDto getStore(
             @PathVariable(required = false) int storeId,
             @AuthenticationPrincipal User user) {
-        return storeService.getStore(storeId, user.getUsername());
+        String socialId = "";
+        if (user != null) {
+            socialId = user.getUsername();
+        }
+
+        return storeService.getStore(storeId, socialId);
     }
 }
diff --git a/src/main/java/com/mpnp/baechelin/store/service/StoreService.java b/src/main/java/com/mpnp/baechelin/store/service/StoreService.java
@@ -166,9 +166,8 @@ private List<StoreCardResponseDto> getStoreCardResponseDtos(User targetUser, Lis
      */
     public StoreCardResponseDto getStore(int storeId, String socialId) {
         Store store = storeRepository.findById(storeId).orElseThrow(() -> new IllegalArgumentException("해당하는 업장이 존재하지 않습니다."));
-        User targetUser = socialId == null ? null : userRepository.findBySocialId(socialId);
 
-        if (targetUser == null) {
+        if (socialId == null) {
             return new StoreCardResponseDto(store, "N");
         } else {
             String isBookmark = "N";