lvm2-flex.service: replace udev.service with systemd-udevd.service #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please explain the intent of this change in the commit message. |
udev.service does not exist, so there is no point of having it in the `After` unit dependency directive. I think the suitable parameter is `systemd-udevd.service`. JIRA-ID: SB-22306 Signed-off-by: Akif Tariq <[email protected]>
|
This looks correct however have we made any observations at runtime after this dependency change? i.e. did we test encrypted-fs after this change? |
|
Also why haven't we considered the second point mentioned in the JIRA ticket?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
udev.service does not exist, so there is no point of having it in the
Afterunit dependency directive. I think the suitable parameter issystemd-udevd.service.JIRA-ID: SB-22306