ci: fix test on Ubuntu #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocavue
commented
Jun 25, 2025
| on: | ||
| push: | ||
| tags: v* | ||
| tags: [v*] |
There was a problem hiding this comment.
Note for reviewer:
Here is a small tweak that's not related to this PR. tags should be an array. See example: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-branches-and-tags
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to test my another PR #73 on my Linux machine, but I found that the testing workflow is broken on Linux. This PR fixes the CI test workflow on Ubuntu. There is a screenshot of GitHub action after this PR:
This PR includes the following changes
Update Playwright to the latest v1.53.1. This should be helpful for system dependency installation.
Remove Node.js v14 from the test workflow. Playwright doesn't support Node.js v14 since v1.34 1.
Add Node.js v24 to the test workflow.
Add
ubuntu-latestto the test workflow.Remove
dom.moduleScripts.enabledfrom the code because it seems that it doesn't work anymore with recent Firefox versions. 2To similar a legacy browser, I set the
renderModernChunks: falseoption to@vitejs/plugin-legacy.Remove Firefix since we don't use its
dom.moduleScripts.enabledanymore. Now all tests are based on Chromium.Footnotes
https://playwright.dev/docs/release-notes#version-134 ↩
https://stackoverflow.com/questions/77450311/how-to-test-non-esm-script-nomodule-on-a-modern-setup ↩