-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add support for Python 3.12 #48
Conversation
pyproject.toml
Outdated
greenlet = { version = ">=3", markers = "python_version >= '3.12'" } | ||
pendulum = { version = "3.0.0b1", markers = "python_version >= '3.12'" } | ||
pyyaml = { version = ">=6.0.1", markers = "python_version >= '3.12'" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All three were needed to satisfy poetry install
on Python 3.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed after rebasing on top of main. Thanks!
pyproject.toml
Outdated
typing-extensions = { version = ">=4.9.0", markers = "python_version >= '3.12'" } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was also needed, but it should probably go into dev-dependencies
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dito.
@amotl Can you merge |
Hi Edgar, thanks for the updates. I've rebased on top of main, and the outcome was that effectively, none of the changes to
Effectively, as no other updates are needed, the patch now only contains updates to project metadata, and the CI configuration. With kind regards, |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
[testenv:pytest] | ||
# Run the python tests. | ||
# To execute, run `tox -e pytest` | ||
envlist = py37, py38, py39, py310, py311 | ||
envlist = py37, py38, py39, py310, py311, py312 | ||
commands = | ||
poetry install -v | ||
poetry run pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While being at it: It feels like Tox isn't used much any longer these days. Let me know if you still use it, or if you think tox.ini
should also be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably doesn't hurt to keep for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amotl!
Thanks for merging! |
About
By refreshing a few dependencies, the package seems to also work on Python 3.12.
Details
The patch has been validated on behalf of a CI run on another patch.