Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add support for Python 3.12 #48

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Dec 14, 2023

About

By refreshing a few dependencies, the package seems to also work on Python 3.12.

Details

The patch has been validated on behalf of a CI run on another patch.

image

@amotl amotl changed the title Add support for Python 3.12 build: Add support for Python 3.12 Dec 14, 2023
@amotl amotl marked this pull request as ready for review December 14, 2023 07:25
pyproject.toml Outdated
Comment on lines 12 to 14
greenlet = { version = ">=3", markers = "python_version >= '3.12'" }
pendulum = { version = "3.0.0b1", markers = "python_version >= '3.12'" }
pyyaml = { version = ">=6.0.1", markers = "python_version >= '3.12'" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three were needed to satisfy poetry install on Python 3.12.

Copy link
Contributor Author

@amotl amotl Dec 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed after rebasing on top of main. Thanks!

pyproject.toml Outdated
Comment on lines 15 to 11
typing-extensions = { version = ">=4.9.0", markers = "python_version >= '3.12'" }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was also needed, but it should probably go into dev-dependencies instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dito.

@edgarrmondragon
Copy link
Member

@amotl Can you merge main into your branch?

@amotl
Copy link
Contributor Author

amotl commented Dec 16, 2023

Hi Edgar,

thanks for the updates. I've rebased on top of main, and the outcome was that effectively, none of the changes to pyproject.toml were needed any longer, and the patch has been amendend correspondingly.

Unfortunately, I can't provide an update to the poetry.lock file, because I am still on Poetry 1.6.1, which renders a largely different output. Can I ask you to take over the branch and add an updated poetry.lock file before merging?

Effectively, as no other updates are needed, the patch now only contains updates to project metadata, and the CI configuration.

With kind regards,
Andreas.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Comment on lines 14 to 20
[testenv:pytest]
# Run the python tests.
# To execute, run `tox -e pytest`
envlist = py37, py38, py39, py310, py311
envlist = py37, py38, py39, py310, py311, py312
commands =
poetry install -v
poetry run pytest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While being at it: It feels like Tox isn't used much any longer these days. Let me know if you still use it, or if you think tox.ini should also be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably doesn't hurt to keep for now

Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amotl!

@edgarrmondragon edgarrmondragon merged commit 9b64ecf into MeltanoLabs:main Dec 17, 2023
8 checks passed
@amotl
Copy link
Contributor Author

amotl commented Dec 18, 2023

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants