-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Exclude information_schema
and pg_catalog
from discovery
#551
base: main
Are you sure you want to change the base?
fix: Exclude information_schema
and pg_catalog
from discovery
#551
Conversation
6c83b46
to
ce81f75
Compare
b87c075
to
a9c0660
Compare
ce81f75
to
6833840
Compare
@edgarrmondragon By default this makes sense, but there's been a number of time's this has been super useful |
@visch oh that's interesting! would you mind elaborating? do you mean for debugging or for something else? |
Had folks use it for schema change reports to see when a schema is updated from the information schema, also when new tables get added. It's been a few wonky use cases but they have happened and it's a big pain to modify the taps that already exist that don't have this functionality. A config value is probably fine as well 🤷 |
Makes sense, I've opened meltano/sdk#2799 for that. I won't be able to fit in the current v0.43 milestone, so it'll have to wait. Maybe this PR will just wait until that's available too. |
a9c0660
to
325511d
Compare
6833840
to
6a0ce07
Compare
325511d
to
e200dd3
Compare
6a0ce07
to
63faaa8
Compare
Related: