Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log based testing, upgrade to postgres16 for testing #316

Merged
merged 25 commits into from
Dec 15, 2023

Conversation

sebastianswms
Copy link
Collaborator

Setup allowing pytest for log_based syncs

Closes #294

@sebastianswms sebastianswms changed the title Log based testing feat: Log based testing Dec 12, 2023
@sebastianswms sebastianswms changed the title feat: Log based testing fix: Log based testing Dec 12, 2023
@visch visch marked this pull request as ready for review December 13, 2023 20:22
@visch visch marked this pull request as draft December 13, 2023 20:22
@sebastianswms sebastianswms marked this pull request as ready for review December 13, 2023 21:23
@sebastianswms sebastianswms requested a review from visch December 13, 2023 21:25
Copy link
Member

@visch visch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to test Log based end to end as well as upgrade postgres to 16

@visch visch changed the title fix: Log based testing fix: Log based testing, upgrade to postgres16 Dec 15, 2023
@visch visch changed the title fix: Log based testing, upgrade to postgres16 fix: Log based testing, upgrade to postgres16 for testing Dec 15, 2023
@visch visch merged commit acaca95 into MeltanoLabs:main Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: AttributeError: 'str' object has no attribute 'append'
3 participants