test: Slightly refactor fixed config values into tests/settings.py
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This intends to make it easier to derive the code into downstream test cases, for databases which are largely compatible with PostgreSQL.
edgarrmondragon
approved these changes
Dec 12, 2023
|
That was quick. Thanks for merging! |
|
@amotl Thank you very much! We love them, the cleaner the better :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Derek and Edgar,
first things first: Thank you so much for your excellent work on MeltanoLabs'
{tap,target}-postgres. We have been able to build upon them at 12 without much ado.We fear we can't contribute anything significant back for the time being, other than cosmetic changes, if you like them. In this spirit, this patch makes a humble start. It was derived from crate-workbench/meltano-tap-cratedb#1, and pulls the database-specific configuration values into a
tests/settings.pyfile, to make it easier to adjust them.With kind regards,
Andreas.
Footnotes
https://github.com/crate-workbench/meltano-tap-cratedb ↩
https://github.com/crate-workbench/meltano-target-cratedb ↩