Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use sqlalchemy.text in tests #305

Merged
merged 1 commit into from
Dec 6, 2023
Merged

test: Use sqlalchemy.text in tests #305

merged 1 commit into from
Dec 6, 2023

Conversation

edgarrmondragon
Copy link
Member

No description provided.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 5, 2023 20:36
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) December 5, 2023 20:37
sebastianswms
sebastianswms approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@sebastianswms sebastianswms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea at some point to take it a step further and make all statements sqlalchemy expression objects.

@edgarrmondragon edgarrmondragon merged commit 9df942d into main Dec 6, 2023
10 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/test/use-sqlalchemy.text-in-tests branch December 6, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianswms sebastianswms sebastianswms approved these changes

@visch visch Awaiting requested review from visch

Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @sebastianswms