fix: Address missing type in for SDK-based type conforming

[edgarrmondragon]

See #239 (comment)

[Lawiss]

Hello @edgarrmondragon, I like the explicit list of possible schema instead of empty object. In term of implementation, it seems that the SDK needs some modifications.

I'm using the data mentioned in #239 (comment).

The first example value is '[{"type": "DEPOT_BAG", "other": "", "quantity": 1}]'.

Using your branch, during the processing of the record (in my tests it is a list of objects ), the step of translation between record values and JSON compatible type will hit this if branch :
https://github.com/meltano/sdk/blob/d6c9ef09bdaee6af039440be7e0b47c97e0090bf/singer_sdk/helpers/_typing.py#L464

Then when trying to convert the list as a "primitive" type, the type matched will be the boolean type (https://github.com/meltano/sdk/blob/d6c9ef09bdaee6af039440be7e0b47c97e0090bf/singer_sdk/helpers/_typing.py#L493) :

    if is_boolean_type(property_schema):
        return None if elem is None else elem != 0

The record is here converted to True and the record is thus non conform to the data extracted.

I don't know if the is a risk to, in case of a list, directly output the record without any modification (relying entirely on sqlalchemy for the type) ?

[edgarrmondragon]

@Lawiss Yeah I started running into the same problems in my own testing. The SDK is probably too eager when conforming types, e.g. I don't think it should try to cast a {"type": ["bool", "string"]} to boolean. Gotta re-think the approach here.

[edgarrmondragon]

Superseded by #307