Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dates can now be parsed only as strings, also migrated to the non dep… #247

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

visch
Copy link
Member

@visch visch commented Sep 22, 2023

Closes #1 , #246

@visch visch changed the title Dates can now be parsed only as strings, also migrated to the non dep… feat: Dates can now be parsed only as strings, also migrated to the non dep… Sep 22, 2023
@visch
Copy link
Member Author

visch commented Sep 22, 2023

@edgarrmondragon I think this is interesting. We could offer a way to override the type to be an empty object like "{}" and then force the datatype from psycopg to be a string which with target-postgres also accepting that gives us full end to end string conversion which bypasses type issues if someone hits them

@visch
Copy link
Member Author

visch commented Sep 23, 2023

@edgarrmondragon I think this is interesting. We could offer a way to override the type to be an empty object like "{}" and then force the datatype from psycopg to be a string which with target-postgres also accepting that gives us full end to end string conversion which bypasses type issues if someone hits them

Thought about this a bit more, and "just" casting everything to a string might be better but that's not super clear to me.

The main benefit of this is you'd get this workflow for users

  1. Try to use tap-postgres
  2. Hit a type issue (Hopefully they'd submit an issue to the tap)
  3. Try the "all strings" config option
  4. Hopefully everything just works

@visch visch merged commit e174f27 into main Sep 27, 2023
4 checks passed
@visch visch deleted the dates_as_strings branch September 27, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Year is out of range
2 participants