Add files via upload #93
Conversation
|
Do we want to install this script automatically when installing the .rpm or .deb? If yes, more changes are needed.
|
There was a problem hiding this comment.
TBH, I'm not really sure what the purpose of this script is. I came across it while just looking at the open PRs for this project, and noticed a few issues while trying to understand what it does. As a maintainer for this package in Debian/Ubuntu, I'd be uncomfortable shipping this script (even if it were relicensed sufficiently) as it does some pretty heavy-handed configuration tasks. Perhaps it could be posted as an example somewhere?
| LINUX_DISTRO="CentOS Linux" | ||
| export LINUX_DISTRO | ||
| fi | ||
| echo "Discovred OS - $LINUX_DISTRO" |
|
|
||
| # ----Bridges configuration ---- | ||
|
|
||
| # Verify OS distrobution type |
| EOF | ||
| } | ||
|
|
||
| options=`getopt -n bfb-multi-install-ubuntu -o b:p:h -l bfb:,password:,help -- "$@"` |
There was a problem hiding this comment.
Should that be bfb-multi-install-ubuntu or just bfb-multi-install?
| fi | ||
| # Verify if seetings not already set. | ||
| if (grep --include=\*.yaml -rnw /etc/netplan/20-tmfifo.yaml -e 'tmfifo_net0'); then | ||
| echo "Static IP already set, skipping to avoid brake current settings" |
| else | ||
| echo create new /etc/netplan/20-tmfifo.yaml file | ||
| touch /etc/netplan/20-tmfifo.yaml | ||
| cat > /etc/netplan/20-tmfifo.yaml <<- EOF |
There was a problem hiding this comment.
What if that file already existed? You could be overwriting someone's config
| # | ||
| # This software product is governed by the End User License Agreement | ||
| # provided with the software product. | ||
| # |
There was a problem hiding this comment.
I hope we're not planning to add proprietary code into this otherwise open source package.
| cat > /etc/sysconfig/network-scripts/ifcfg-br_tmfifo << EOF | ||
| DEVICE="br_tmfifo" | ||
| BOOTPROTO="static" | ||
| IPADDR="192.168.100.1" |
There was a problem hiding this comment.
how do we know this is an OK subnet to use? What if your default route used 192.168.100.1 as a gateway?
Added new bfb-multi-install to scripts