hw-mgmt: scripts: Added hw-mgmt done WatchDog. #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bspguy
requested review from
sholeksandr,
ciju-nvidia,
felixradensky,
mshych,
yyehudai and
vadimp-nvidia
as code owners
|
Can one of the admins verify this patch? |
ciju-nvidia
reviewed
Jul 12, 2024
usr/usr/bin/hw-management-done.sh
Outdated
| # | ||
| source hw-management-helpers.sh | ||
|
|
||
| trace_udev_events "hw-mngmt done called" |
There was a problem hiding this comment.
This function is meant for udev events tracing only. Use log_info() instead
ciju-nvidia
reviewed
Jul 12, 2024
usr/usr/bin/hw-management-done.sh
Outdated
| current_time=$(date +%s%3N) | ||
|
|
||
| # Read the last reset time atomically. | ||
| if [[ -f "$WATCHDOG_RESET_FILE" ]]; then |
There was a problem hiding this comment.
Please change the name from watchdog to something like monitor, etc.
There was a problem hiding this comment.
@vadimp-nvidia @ciju-nvidia What is your decision?
wd/monitor?
ciju-nvidia
reviewed
Jul 12, 2024
usr/usr/bin/hw-management-done.sh
Outdated
| # Update the status file. | ||
| echo "1" > "$WATCHDOG_STATUS_FILE" | ||
| # Update syslog. | ||
| logger "hw-management script done!" |
bspguy
force-pushed
the
hw-mgmt-watchdog
branch
4 times, most recently
from
aa30ff4
to
12a87b1
Compare
bspguy
force-pushed
the
hw-mgmt-watchdog
branch
2 times, most recently
from
7842bdf
to
2925a60
Compare
Signed-off-by: Roy Cohen <[email protected]>
bspguy
force-pushed
the
hw-mgmt-watchdog
branch
from
c8247e5
to
c0656ae
Compare
vadimp-nvidia
approved these changes
Sep 26, 2024
bspguy
requested review from
mshych
and removed request for
mshych and
yyehudai
|
Please review @ciju-nvidia @oleksandrivantsiv @oleksandrivantsiv @mshych @felixradensky |
vadimp-nvidia
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a WD, for tracking symbolic link creation.