Skip to content

Commit

Permalink
feat: Upgrade Spring and replace Jcabi Plugin by AspectJ Maven Plugin -
Browse files Browse the repository at this point in the history
Meeds-io/meeds#2417

Prior to this change, the jcabi maven plugin was used to weave classes for annotation processing, especially  and  annotations. This plugin isn't maintained and should be replace by the default AspectJ libraries for Annotation Processing. In addition, the Jcabi plugin makes the build longer and takes a lot of time in addition to heigh I/O operations on disk. This change applies the required configuration (In addition to Meeds-io/maven-parent-pom@bea09a8) in order to replace usage of Jcabi plugin.
  • Loading branch information
boubaker committed Sep 25, 2024
1 parent 66b5c12 commit bcffdfb
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 20 deletions.
10 changes: 0 additions & 10 deletions component/api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,4 @@
<artifactId>jsoup</artifactId>
</dependency>
</dependencies>

<build>
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
<groupId>com.jcabi</groupId>
<artifactId>jcabi-maven-plugin</artifactId>
</plugin>
</plugins>
</build>
</project>
4 changes: 2 additions & 2 deletions component/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<plugin>
<groupId>org.bsc.maven</groupId>
<artifactId>maven-processor-plugin</artifactId>
<version>5.0</version>
<version>5.1</version>
<executions>
<execution>
<id>process</id>
Expand All @@ -79,7 +79,7 @@
<dependency>
<groupId>org.hibernate.orm</groupId>
<artifactId>hibernate-jpamodelgen</artifactId>
<version>6.4.1.Final</version>
<version>6.5.3.Final</version>
</dependency>
</dependencies>
</plugin>
Expand Down
4 changes: 0 additions & 4 deletions component/notification/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@
<build>
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
<groupId>com.jcabi</groupId>
<artifactId>jcabi-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
Expand Down
4 changes: 0 additions & 4 deletions component/service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@
<build>
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
<groupId>com.jcabi</groupId>
<artifactId>jcabi-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
Expand Down
20 changes: 20 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,28 @@
</dependencies>
</dependencyManagement>

<dependencies>
<dependency>
<groupId>io.meeds.portal</groupId>
<artifactId>portal.component.common</artifactId>
</dependency>
</dependencies>
<build>
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<configuration>
<aspectLibraries>
<aspectLibrary>
<groupId>io.meeds.portal</groupId>
<artifactId>portal.component.common</artifactId>
</aspectLibrary>
</aspectLibraries>
</configuration>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
Expand Down

0 comments on commit bcffdfb

Please sign in to comment.