Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when searching notes - EXO-65101 - Meeds-io/meeds#1038 #703

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ahamdi
Copy link
Member

@ahamdi ahamdi commented Jul 24, 2023

Priori to this fix a NullPointerException was thrown when there are search results for Notes.
The error is thrown because we used to index and search Notes attachments, which is no more the case thanks to the curent fix. It also enhances search results by appending the ⭐ character to searched words

@ahamdi ahamdi enabled auto-merge (squash) July 24, 2023 14:15
@ahamdi ahamdi requested review from Jihed525 and akhanfir July 24, 2023 14:15
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ahamdi ahamdi merged commit 5d57e6f into feature/maintenance Jul 24, 2023
6 of 7 checks passed
@ahamdi ahamdi deleted the fix/EXO-65101 branch July 24, 2023 14:25
exo-swf pushed a commit that referenced this pull request Jul 24, 2023
Priori to this fix a NullPointerException was thrown when there are
search results for Notes.
The error is thrown because we used to index and search Notes
attachments, which is no more the case thanks to the curent fix. It also
enhances search results by appending the ⭐ character to searched
words
ahamdi added a commit that referenced this pull request Jul 26, 2023
Priori to this fix a NullPointerException was thrown when there are
search results for Notes.
The error is thrown because we used to index and search Notes
attachments, which is no more the case thanks to the curent fix. It also
enhances search results by appending the ⭐ character to searched
words
ahamdi added a commit that referenced this pull request Jul 26, 2023
Priori to this fix a NullPointerException was thrown when there are
search results for Notes.
The error is thrown because we used to index and search Notes
attachments, which is no more the case thanks to the curent fix. It also
enhances search results by appending the ⭐ character to searched
words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants