fix : [Notes] insert position is wrong EXO-65312 - Meeds-io/meeds#1019 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when create new notes page, add 3 lines of content and on 4th line insert an image,this image inserted on top of notes content . To fix this problem, remove the reset of the ckeditor when opening the customPluginsDrawer drawer. After this change, image inserted at last cursor position.
|
Kudos, SonarCloud Quality Gate passed!
|
ahamdi
approved these changes
Jul 12, 2023
exo-swf
pushed a commit
that referenced
this pull request
Jul 19, 2023
#698) Prior to this change, when create new notes page, add 3 lines of content and on 4th line insert an image,this image inserted on top of notes content . To fix this problem, remove the reset of the ckeditor when opening the `customPluginsDrawer` drawer. After this change, image inserted at last cursor position.
Jihed525
pushed a commit
that referenced
this pull request
Jul 24, 2023
#698) Prior to this change, when create new notes page, add 3 lines of content and on 4th line insert an image,this image inserted on top of notes content . To fix this problem, remove the reset of the ckeditor when opening the `customPluginsDrawer` drawer. After this change, image inserted at last cursor position. (cherry picked from commit 7a37f1c)
Jihed525
pushed a commit
that referenced
this pull request
Jul 24, 2023
#698) Prior to this change, when create new notes page, add 3 lines of content and on 4th line insert an image,this image inserted on top of notes content . To fix this problem, remove the reset of the ckeditor when opening the `customPluginsDrawer` drawer. After this change, image inserted at last cursor position. (cherry picked from commit 7a37f1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when create new notes page, add 3 lines of content and on 4th line insert an image,this image inserted on top of notes content . To fix this problem, remove the reset of the ckeditor when opening the
customPluginsDrawerdrawer. After this change, image inserted at last cursor position.