Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix import featured images - EXO-74718 - Meeds-io/meeds#2499 #1171

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

hakermi
Copy link
Member

@hakermi hakermi commented Oct 16, 2024

Prior to this change, when import notes with featured images, the featured image are not correctly imported due to wrong extraction of featuredId from exported fileName beside a wrong handle of different conflict actions.
This PR makes sure to correctly extarct the export featured image id to correctly import featured images.

Prior to this change, when import notes with featured images, the featured image are not correctly imported due to wrong extractin of featuredId from exported fileName
beside a wrong handle of different conflict actions.
This PR makes sure to correctly extarct the export featured image id to correctly import featured images.
@hakermi hakermi requested a review from azayati October 16, 2024 07:57
Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hakermi hakermi merged commit f30d33b into feature/experience Oct 16, 2024
7 checks passed
@hakermi hakermi deleted the TASK-74718 branch October 16, 2024 08:19
hakermi added a commit that referenced this pull request Oct 16, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
hakermi added a commit that referenced this pull request Oct 16, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
exo-swf pushed a commit that referenced this pull request Oct 16, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants