-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Displaying the note title limit warning message only when trying to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129
Quality Gate passedIssues Measures |
azayati
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
azayati
pushed a commit
that referenced
this pull request
Sep 19, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
rdenarie
pushed a commit
that referenced
this pull request
Sep 19, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
sofyenne
added a commit
that referenced
this pull request
Sep 20, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
sofyenne
added a commit
that referenced
this pull request
Sep 20, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
azayati
pushed a commit
that referenced
this pull request
Sep 20, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
azayati
pushed a commit
that referenced
this pull request
Sep 24, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
azayati
pushed a commit
that referenced
this pull request
Oct 1, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
azayati
pushed a commit
that referenced
this pull request
Oct 9, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
azayati
pushed a commit
that referenced
this pull request
Oct 11, 2024
…g to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118)
azayati
pushed a commit
that referenced
this pull request
Oct 11, 2024
feat: Update the order of the notes notification section - EXO-73571 - Meeds-io/MIPs#129 (#1119) feat: Include properties in note export/import - EXO-73694 - Meeds-io/MIPs#129 (#1077) Include properties in note export/import feat: Include note properties in import/export notes - EXO-73694 - Meeds-io/MIPs#129 (#1099) Include note properties in import/export notes fix: fix processing featured images while export a note - EXO-73694 - Meeds-io/MIPs#129 fix processing featured images while export a note feat: Reactivate cropping drawer usage for note featured image property - EXO-73967 - Meeds-io/MIPs#129 (#1103) Reactivate cropping drawer usage for note featured image property fix: Ui/ux issues in note create/switch translation - EXO-73222, EXO-74157 - Meeds-io/MIPs#129 (#1108) Ui/ux issues in note create/switch translation: - featured image not reset when automatic translation is not available while creating a new translation - "draft saving..." message remains displayed when adding a new translation while the automatic translation is not available - switch between translations enables the save button without existing of draft feat: Add a limit on note summary property value - EXO-74215 - Meeds-io/MIPs#129 (#1111) Add a limit on note summary property value feat: Update note action menu icons font size - EXO-74218 - Meeds-io/MIPs#129 (#1112) Update note action menu icons font size feat: Displaying the note title limit warning message only when trying to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118) feat: Disable save button when editing note properties - EXO-74267 - Meeds-io/MIPs#129 (#1125) feat: Add tooltip to properties button - EXO-74272 - Meeds-io/MIPs#129 (#1131) fix: Fix displaying content detail for public sites - EXO-74419 - Meeds-io/MIPs#129 (#1140)
azayati
pushed a commit
that referenced
this pull request
Oct 11, 2024
feat: Update the order of the notes notification section - EXO-73571 - Meeds-io/MIPs#129 (#1119) feat: Include properties in note export/import - EXO-73694 - Meeds-io/MIPs#129 (#1077) Include properties in note export/import feat: Include note properties in import/export notes - EXO-73694 - Meeds-io/MIPs#129 (#1099) Include note properties in import/export notes fix: fix processing featured images while export a note - EXO-73694 - Meeds-io/MIPs#129 fix processing featured images while export a note feat: Reactivate cropping drawer usage for note featured image property - EXO-73967 - Meeds-io/MIPs#129 (#1103) Reactivate cropping drawer usage for note featured image property fix: Ui/ux issues in note create/switch translation - EXO-73222, EXO-74157 - Meeds-io/MIPs#129 (#1108) Ui/ux issues in note create/switch translation: - featured image not reset when automatic translation is not available while creating a new translation - "draft saving..." message remains displayed when adding a new translation while the automatic translation is not available - switch between translations enables the save button without existing of draft feat: Add a limit on note summary property value - EXO-74215 - Meeds-io/MIPs#129 (#1111) Add a limit on note summary property value feat: Update note action menu icons font size - EXO-74218 - Meeds-io/MIPs#129 (#1112) Update note action menu icons font size feat: Displaying the note title limit warning message only when trying to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118) feat: Disable save button when editing note properties - EXO-74267 - Meeds-io/MIPs#129 (#1125) feat: Add tooltip to properties button - EXO-74272 - Meeds-io/MIPs#129 (#1131) fix: Fix displaying content detail for public sites - EXO-74419 - Meeds-io/MIPs#129 (#1140) fix: Fix insert note page option - EXO-74420 - Meeds-io/MIPs#129 (#1155)
azayati
pushed a commit
that referenced
this pull request
Oct 11, 2024
feat: Update the order of the notes notification section - EXO-73571 - Meeds-io/MIPs#129 (#1119) feat: Include properties in note export/import - EXO-73694 - Meeds-io/MIPs#129 (#1077) Include properties in note export/import feat: Include note properties in import/export notes - EXO-73694 - Meeds-io/MIPs#129 (#1099) Include note properties in import/export notes fix: fix processing featured images while export a note - EXO-73694 - Meeds-io/MIPs#129 fix processing featured images while export a note feat: Reactivate cropping drawer usage for note featured image property - EXO-73967 - Meeds-io/MIPs#129 (#1103) Reactivate cropping drawer usage for note featured image property fix: Ui/ux issues in note create/switch translation - EXO-73222, EXO-74157 - Meeds-io/MIPs#129 (#1108) Ui/ux issues in note create/switch translation: - featured image not reset when automatic translation is not available while creating a new translation - "draft saving..." message remains displayed when adding a new translation while the automatic translation is not available - switch between translations enables the save button without existing of draft feat: Add a limit on note summary property value - EXO-74215 - Meeds-io/MIPs#129 (#1111) Add a limit on note summary property value feat: Update note action menu icons font size - EXO-74218 - Meeds-io/MIPs#129 (#1112) Update note action menu icons font size feat: Displaying the note title limit warning message only when trying to add more than the limit - EXO-74261 - Meeds-io/MIPs#129 (#1118) feat: Disable save button when editing note properties - EXO-74267 - Meeds-io/MIPs#129 (#1125) feat: Add tooltip to properties button - EXO-74272 - Meeds-io/MIPs#129 (#1131) fix: Fix displaying content detail for public sites - EXO-74419 - Meeds-io/MIPs#129 (#1140) fix: Fix insert note page option - EXO-74420 - Meeds-io/MIPs#129 (#1155) fix: Fix image cropper styles in notes-editor - EXO-74717 - Meeds-io/MIPs#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.