Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add kb jwt header #26

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Feature/add kb jwt header #26

merged 3 commits into from
Feb 19, 2024

Conversation

ragnika
Copy link
Contributor

@ragnika ragnika commented Feb 19, 2024

add parameter to allow adding header params to key-binding JWT.

Renamed revealDisclosure in holder.ts to selectDisclosure to better reflect the intention of the function

linasi
linasi approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@linasi linasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javereec javereec merged commit eab5f61 into main Feb 19, 2024
2 checks passed
@javereec javereec deleted the feature/add-kb-jwt-header branch February 19, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linasi linasi linasi approved these changes

@javereec javereec javereec approved these changes

@vijayshiyani vijayshiyani Awaiting requested review from vijayshiyani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ragnika @javereec @linasi