Introducing thread/microblog locking #1773
Conversation
BentiGorlich
added
enhancement
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
ebba215 to
3234d80
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Nope, ready to be reviewed :) |
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
71bc4bf to
c81f5ca
Compare
| @@ -113,6 +115,8 @@ public function doWork(MessageInterface $message): void | |||
| $this->logger->info('[CreateHandler::doWork] Did not create the post, because the user\'s instance is banned'); | |||
| } catch (UserBlockedException $e) { | |||
There was a problem hiding this comment.
Unrelated to your change, but I think $e can be removed here as well. Since its not used.
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
c81f5ca to
50c314a
Compare
|
I notice you recently made (yesterday) some discoveries in this PR.. maybe its a good idea to wait with large PR after the 1.9.0 release..? Do you agree? |
|
I only resolved the merge conflict. But I don't need to have this in 1.9.0 |
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
8349166 to
01570d2
Compare
| use Doctrine\DBAL\Schema\Schema; | ||
| use Doctrine\Migrations\AbstractMigration; | ||
|
|
||
| final class Version20251031174052 extends AbstractMigration |
There was a problem hiding this comment.
due to the fact we might introduced other migrations.. it might be wise to upgrade the file name and class name to reflect the current date again..
There was a problem hiding this comment.
In theory yes, but I have already been running this migration locally and on gehirneimer, so it would complicate things there... If you do not insist on it, I'd prefer to leave it as is
There was a problem hiding this comment.
OK let's hope then it won't case any issues and symfony migration is smart enough
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
b1cef63 to
f17c887
Compare
- Threads and microblogs can now be locked so comments cannot be added anymore. This includes: - API support (new scopes) - ActivityPub support (`Lock` activity, post editing, etc.) - Authors and moderators can lock threads and microblogs - Add modlog items for the new lock and unlock events - Add tests for basically everything
- The `UpdateHandler` used the wrong boolean logic for setting the isLocked (which is the inverse of `commentsEnabled`) - Add write to `isLocked` during the creation of entries and posts via ActivityPub
BentiGorlich
force-pushed
the
new/lock-entries-and-posts
branch
from
f17c887 to
8aa74f3
Compare
|
Sorry, I had to fix conflicts :) |
- in #1773 an consent key was missing (noticed through test warnings) -> add that - also add translation for the lock consent, for both entries and posts
Lockactivity, post editing, etc.)Related to #248