Repository navigation
Conversation
Quitting left the active session and the transaction executor's connection open, so drivers fell back to their own atexit cleanup. snowflake-connector-python now warns about that: FutureWarning: Connection was not explicitly closed before process exit. Close both synchronously in on_unmount, which runs on every exit path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Quitting sqlit while connected to Snowflake prints:
On exit the app shuts down the process worker but never closes the active
ConnectionSessionor theTransactionExecutor's persistent connection. Drivers fall back to their own atexit cleanup; snowflake-connector-python now warns about it and plans to drop that fallback.Fix
on_unmount(runs on every exit path, not onlyaction_quit) now closes the session and the transaction executor synchronously._disconnect_silentisn't reused because it closes the session in a background worker and refreshes the UI, neither of which fits teardown.Tests
tests/ui/test_close_connections_on_exit.py: fails without the fix, passes with it.pytest tests/unit tests/ui/test_light_theme_contrast.py tests/ui/test_close_connections_on_exit.py: 1321 passed, 3 skipped.main.pyexist onmain).🤖 Generated with Claude Code