Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has a few changes to make
UploadThread
more resilientgetBackupStatus
will now directly return strings that do not need any replacements. in the past this function has often caused exceptions when called whileUploadThread
was in an inconsistent state, this reduces to chance of an exception.run
has been split intorun
andrun_internal
.run_internal
has the bulk of the actual upload logic.run
will wraprun_internal
in a try block to make sure thatlastBackupSuccessful
andbackupStatus
are properly set when encountering an exception or returning early. both of those have caused problems in the past.it also prevents
UploadThread
getting into an broken state withlocal-keep-count: 0
(resulting in an exception on further actions)