-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: merge staging to master #41
Conversation
Pipeline Attempt on 963022829 for b8fa1eb https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/963022829 |
Pipeline Attempt on 970528879 for e7a1039 https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/970528879 |
Pipeline Attempt on 970553102 for 84bd5caba363f9f9e09d8605cbca44563274c8ec https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/970553102 |
CI was failing due to the b8fa1eb commit. The mac job passes when I revert this commit. A quick search reveals the following issues which MAY be related.
Either we don't push up these optional dependencies in the package lockfile. Or I need to have a look at the version script. |
The package-lock.json is supposed to be updated. Something is wrong on the mac job if that's the case. |
Also this is Also what does |
Is it because it is failing to install an optional dependency on the mac build? That's weird cause only the windows binaries didn't work. Or was the mac release don't incorrectly? |
Pipeline Attempt on 970569052 for e7a1039 https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/970569052 |
Actually I hit this before. Completely delete |
But yes the version script or prepublish script doesn't seem to be properly updating the |
Regenerating the
Updating to the latest versions does not fix the problem. Any insights @CMCDragonkai ? |
Pin it against the |
Try reproducing the errors, and give the input to the |
Should remove any vestigial comments like:
|
here are the reproducible tests
|
Pipeline Attempt on 970724656 for 824c4cb https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/970724656 |
Reviewing the package lockfile changes, the only version that actually changed was I'm still looking into this. |
Are you sure? The failure in the calls all involve |
Didn't you say using the old |
This reverts commit b8fa1eb.
Pipeline Attempt on 971729469 for 2a14b5a https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971729469 |
Pipeline Attempt on 971737491 for 2a14b5a https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971737491 |
Pipeline Succeeded on 971737491 for 2a14b5a https://gitlab.com/MatrixAI/open-source/js-quic/-/pipelines/971737491 |
This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.