Makes js-lint invoke bundled prettier cli rather than target repo's prettier #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invoke local prettier instead of repo prettier
tegefaulkes
reviewed
May 12, 2025
Comment on lines
+141
to
+145
| const require = createRequire(import.meta.url); | ||
| let prettierBin: string | null = null; | ||
| try { | ||
| childProcess.execFileSync('prettier', prettierArgs, { | ||
| stdio: 'inherit', | ||
| windowsHide: true, | ||
| encoding: 'utf-8', | ||
| shell: platform === 'win32', | ||
| cwd: process.cwd(), | ||
| }); | ||
| // Resolves to @matrixai/lint/node_modules/prettier/bin/prettier.cjs | ||
| prettierBin = require.resolve('prettier/bin/prettier.cjs'); |
There was a problem hiding this comment.
Don't use createRequire this is hack to allow for synchronous dynamic importing of code. If you need to resolve a path to an absolute use import.meta.url to get the current directory and use path.resolve to resolve that to an absolute path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the current way js-lint invokes prettier by invoking its local version rather than trying to look for prettier on the target repo's PATH
Issues Fixed
Tasks
Final checklist