Use commander package to replace current implementation of CLI options #16
+153
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstalled minimatch for glob matching
… the lint script recognize --eslint flag properly
…nfig and matrix config stuff if an explicit glob is given
… args for the lint command
8 tasks
tegefaulkes
reviewed
May 12, 2025
Comment on lines
31
to
+34
| async function main(argv = process.argv) { | ||
| argv = argv.slice(2); | ||
| await program.parseAsync(argv); | ||
| const options = program.opts<CLIOptions>(); | ||
|
|
There was a problem hiding this comment.
This isn't how we use Commander. The main code needs to be in the .action(async () => {}) callback of the program. https://www.npmjs.com/package/commander#action-handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the commander package and uses it to implement CLI options. This PR will also implement additional CLI options for defining file matching patterns and shellcheck patterns
Issues Fixed
Tasks
Final checklist