Adding handling for expired intermediate certs when verifying client #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpired intermediate certificates
|
I should add 1 more test for a chain that is Also @aryanjassal have a quick review of this just to get an idea of the change. |
|
We need a new release for this for my node to continue working. |
Comment on lines
+650
to
+654
| let leafCert = true; | ||
| for (let certIndex = 0; certIndex < certChain.length; certIndex++) { | ||
| const cert = certChain[certIndex]; | ||
| const certNext = certChain[certIndex + 1]; | ||
| if (now < cert.notBefore || now > cert.notAfter) { | ||
| if (leafCert && (now < cert.notBefore || now > cert.notAfter)) { |
There was a problem hiding this comment.
This is a bit confusing when it's set to true and then checked. The order of switching booleans may be clearer if it was the other way around.
There was a problem hiding this comment.
As in, started as false and had a different name?
|
Starting something as true and then checking if it is true is just a bit weird even if you're later switching it to false. In fact it sounds like you should be doing an initial step on the head and then loop over the tail. These should be 2 different procedures.
23 Aug 2024 10:45:36 Brian Botha ***@***.***>:
…
***@***.**** commented on this pull request.
----------------------------------------
In src/nodes/utils.ts[#788 (comment)]:
> + let leafCert = true;
for (let certIndex = 0; certIndex < certChain.length; certIndex++) {
const cert = certChain[certIndex];
const certNext = certChain[certIndex + 1];
- if (now < cert.notBefore || now > cert.notAfter) {
+ if (leafCert && (now < cert.notBefore || now > cert.notAfter)) {
As in, started as false and had a different name?
—
Reply to this email directly, view it on GitHub[#788 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAE4OHNEIW7XC3PZ35VCDI3ZS2A25AVCNFSM6AAAAABMR4W3WGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJWGAYTGOJTGE].
You are receiving this because you commented.
[Tracking image][https://github.com/notifications/beacon/AAE4OHOU5SREWDEPRGBG37LZS2A25A5CNFSM6AAAAABMR4W3WGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUGPAFGW.gif]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with expired intermediate certificates preventing connections when connecting with a client.
Issues Fixed
Fixes #787
Tasks
verifyClientCertificateChainthat prevented connections when we had an expired certificate when the chain should still be valid.verifyServerCertificateChainfor any similar issues.Final checklist