Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Segregation #775

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Network Segregation #775

merged 1 commit into from
Sep 2, 2024

Conversation

amydevs
Copy link
Member

@amydevs amydevs commented Jul 18, 2024

Description

This PR aims to implement network segregation via a fractal network pattern enforced through token verification,

Issues Fixed

Tasks

  • 1. Implement Token Verification Logic into RPC system

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@amydevs amydevs changed the title wip: x509 extensions Network Segregation Jul 18, 2024
@amydevs amydevs force-pushed the feature-network-segregation branch 2 times, most recently from 0b4498b to c69c560 Compare July 25, 2024 03:28
@tegefaulkes
Copy link
Contributor

@amydevs avoid wip commits. Be sure to add a description to them wip: did a thing just so we can get an idea of the changes from the commit message. On top of that, if you know CI wont pass then add [ci skip] in the commit message as well.

The PR description needs to be updated as well since we've subdivided the work. This is focusing solely on the authentication logic for the network access claims now. So the description and tasks need to reflect that.

Copy link

linear bot commented Aug 13, 2024

Copy link

linear bot commented Aug 20, 2024

@amydevs
Copy link
Member Author

amydevs commented Aug 20, 2024

I've added the authentication logic + tests, i'm going to look as to where to slot in the logic that will prevent calls being made to the RPC client when the connection has not yet been authenticated, as well as where to drop the connection if authentication fails.

@amydevs amydevs force-pushed the feature-network-segregation branch from db7f8ce to fad5e05 Compare August 22, 2024 02:29
@CMCDragonkai
Copy link
Member

Merge this with just mainnet and testnet segregation.

Start with --network=X use the X is the unique identifier for the network. Then just use 1 single token the ClaimNetworkAccess token to indicate what network you're claiming to access to.

Special case for --network='' which is an empty string. You could claim with an empty string as the unique identifier, or we can say it's just equivalent to null or undefined meaning there's no token at all.

Separate out the work for PKE. PKE side of things can be done later.

@amydevs amydevs force-pushed the feature-network-segregation branch 4 times, most recently from 0fd2f38 to b37307a Compare September 2, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Network Segregation/Authentication Token Logic
3 participants