Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards Compatibility for Discovery.processClaimLinkIdentity #741

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

amydevs
Copy link
Member

@amydevs amydevs commented Jun 13, 2024

Description

This PR re-adds backwards compatibility to the Discovery system to deal with claims that do not include the providerIdentityClaimId.

Issues Fixed

Tasks

  • 1. Add backwards compatibility logic for claims w/o `providerIdentityClaimId``

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@amydevs
Copy link
Member Author

amydevs commented Jun 13, 2024

image

I managed to discover the highlighted node using a claim that was created using polykey-cli v0.4.0

@amydevs amydevs merged commit 1166e50 into staging Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Backwards Compatibility of Discovery Mechanism
1 participant