Expanding nodes domain tests

[tegefaulkes]

Description

This expands the nodes domain testing that was skipped during the nodes refactoring rush.

Issues Fixed

• Fixes: Complete NodeManager tests from decentralised nodes refactor #642

Tasks

• 1. findNode operations handle offline nodes/connection failures. Make sure that a single failing connection wont take up the full timeout of the process.
• 2. Network entry with syncNodeGraph, connects to 2 seed nodes and check we discover all active nodes in the network. Include active connection and direct connection links.
• 3. network entry with syncNodegraph handles offline nodes - just checking if we can handle offline nodes for the initial connections. The other connections are done by findNode. Also check that including our own NodeId in the initial connections list wont break.
• 4. refresh buckets - simple test, check that a scheduled refreshBucket triggers a findNode operation within that bucket. Not really worth the test.
• 5. checking NodeGraph updates when a connection is made.
• 6. test MDNS functionality. On that note, we need a way to disable it for testing so it doesn't break the findNode tests. Maybe just mock it out for most tests.
• 7. bunch of tests for adding new nodes and the background pinging tasks.
• 8. tests for signalling non-blocking and rate limiting logic.

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[ghost]

👇 Click on the image for a new way to code review

Legend

[tegefaulkes]

I did some exploring in one of the tests. The EventTarget leak is likely inside of the QUIC code. I'll have to have a look around in there.

[CMCDragonkai]

I did some exploring in one of the tests. The EventTarget leak is likely inside of the QUIC code. I'll have to have a look around in there.

Can you expand? A bug issue in js-quic?