Backwards Compatibility of Discovery Mechanism

[amydevs]

Specification

In order to adhere to a federated system, we need to adhere to the following principles when dealing with non-breaking changes:

1. version schema is a single number that changes if it is truly a compat break
2. the whole discovery system must be forwards compatible
3. the whole discovery system must be backwards compatible

What happened here, is that it was a field addition, but the logic that would process a claim without the field addition was removed.

For forwards compatibility, this would still allow an old node would be able to discover a new node.

But for backwards compatibility, this prevented the ability, the removed logic would no longer be able to discover an old node.

Additional context

#737

Tasks

1. Return old discovery logic

[linear]

ENG-341 Backwards Compatibility of Discovery Mechanism

[amydevs]

{
  c241cd7219eafd37258af82de0b18cb3: {
    payload: {
      iat: 1718152555,
      iss: 'vcj3ufun2506jn44q7rr9bc1hv4c6eebicusfj1bl9sr27ookknlg',
      jti: 'v0pj8tllneho0169hv7vbh2g39o',
      nbf: 1718152555,
      prevClaimId: 'v0phklr879to0169hv7vbh2g39o',
      prevDigest: 'z2DrjgbJrZvLH1h319LrUMkgeQY4DXrAGMXwZoRZaezC4mq4nNP',
      seq: 2,
      sub: '["github.com","CMCDragonkai"]',
      typ: 'ClaimLinkIdentity'
    },
    signatures: [ [Object] ]
  },
  '25cc937e27085b05360926af70925192': {
    payload: {
      iat: 1714728656,
      iss: 'vcj3ufun2506jn44q7rr9bc1hv4c6eebicusfj1bl9sr27ookknlg',
      jti: 'v0phklr879to0169hv7vbh2g39o',
      nbf: 1714728656,
      prevClaimId: null,
      prevDigest: null,
      seq: 1,
      sub: '["github.com","CMCDragonkai"]',
      typ: 'ClaimLinkIdentity'
    },
    signatures: [ [Object] ]
  }
}

console.log from Discovery domain shows that both claims are processed ^