docker compose cleanup #69
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the current status of this? |
|
So can I close this? |
| - DB_USERNAME=tasky | ||
| - DB_PASSWORD=tasky | ||
| - DB_USERNAME=usernator | ||
| - DB_PASSWORD=usernator |
There was a problem hiding this comment.
Why use other user credentials here?
| @@ -26,7 +27,11 @@ class ApiService { | |||
| private apiUrl: string; | |||
|
|
|||
| constructor() { | |||
| this.apiUrl = process.env.NODE_ENV === "production" ? "https://api.code-canvas.app" : "http://localhost:3002"; | |||
| //this.apiUrl = process.env.NODE_ENV === "production" ? "https://api.code-canvas.app" : "http://localhost:3002"; | |||
There was a problem hiding this comment.
Please remove this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generally cleans up and polishes the whole docker setup. This includes parts of the web/frontend service, as it should be able to load its configuration from runtime env vars but currently is not.
Will further look into that tomorrow.