Fix mem_per_cpu in SlurmIO not being passed as snake_case#44
Merged
ml-evs merged 1 commit intoMatgenix:developfrom Aug 7, 2024
janosh:fix-mem-per-thread
Merged
Fix mem_per_cpu in SlurmIO not being passed as snake_case#44ml-evs merged 1 commit intoMatgenix:developfrom janosh:fix-mem-per-thread
mem_per_cpu in SlurmIO not being passed as snake_case#44ml-evs merged 1 commit intoMatgenix:developfrom
janosh:fix-mem-per-thread
Conversation
mem_per_cpu in SlurmIOmem_per_cpu in SlurmIO not being passed as snake_case
Collaborator
Author
|
a thing to note here is that this wasn't caught by tests because it seems the template insertion isn't run by any test but probably should be? |
ml-evs
approved these changes
Aug 7, 2024
Member
ml-evs
left a comment
There was a problem hiding this comment.
a thing to note here is that this wasn't caught by tests because it seems the template insertion isn't run by any test but probably should be?
Yeah, I was looking into writing some tests for this as part of my review, but let's not hold this up. Thanks for reporting and fixing @janosh!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
passing
memory_per_threadcurrently crashes job submissions withValueErrorreason being that it's mapped to
mem-per-gpuby_qresources_mappingqtoolkit/src/qtoolkit/io/slurm.py
Line 558 in 346c0d6
but
qtoolkit/src/qtoolkit/io/slurm.py
Line 157 in 346c0d6
expects it as snake case