-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to set Job priority #183
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #183 +/- ##
===========================================
+ Coverage 47.92% 47.99% +0.07%
===========================================
Files 43 43
Lines 5156 5165 +9
Branches 1118 1121 +3
===========================================
+ Hits 2471 2479 +8
- Misses 2425 2429 +4
+ Partials 260 257 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thx! Just one or two comments and suggestions.
One thing I mention here (but does not need to be done in this PR) is that maybe we could/should document all the things that are in set_run_config in subsubtitles.
Co-authored-by: David Waroquiers <[email protected]>
Co-authored-by: David Waroquiers <[email protected]>
Co-authored-by: David Waroquiers <[email protected]>
75d6712
to
5615349
Compare
While the
JobDoc
always had apriority
attribute that is taken into account to sort the order of execution of jobs, there was actually no direct way of setting it. This PR introduces options to choose the priority at submission and update it in the DB.