Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set Job priority #183

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Option to set Job priority #183

merged 7 commits into from
Sep 27, 2024

Conversation

gpetretto
Copy link
Contributor

While the JobDoc always had a priority attribute that is taken into account to sort the order of execution of jobs, there was actually no direct way of setting it. This PR introduces options to choose the priority at submission and update it in the DB.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.99%. Comparing base (6281728) to head (5615349).

Files with missing lines Patch % Lines
src/jobflow_remote/cli/job.py 50.00% 2 Missing ⚠️
src/jobflow_remote/config/jobconfig.py 0.00% 2 Missing ⚠️
src/jobflow_remote/jobs/jobcontroller.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
+ Coverage    47.92%   47.99%   +0.07%     
===========================================
  Files           43       43              
  Lines         5156     5165       +9     
  Branches      1118     1121       +3     
===========================================
+ Hits          2471     2479       +8     
- Misses        2425     2429       +4     
+ Partials       260      257       -3     
Files with missing lines Coverage Δ
src/jobflow_remote/jobs/data.py 67.55% <100.00%> (+0.14%) ⬆️
src/jobflow_remote/jobs/submit.py 81.48% <ø> (ø)
src/jobflow_remote/cli/job.py 20.86% <50.00%> (+0.42%) ⬆️
src/jobflow_remote/config/jobconfig.py 20.00% <0.00%> (-1.74%) ⬇️
src/jobflow_remote/jobs/jobcontroller.py 35.59% <0.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thx! Just one or two comments and suggestions.
One thing I mention here (but does not need to be done in this PR) is that maybe we could/should document all the things that are in set_run_config in subsubtitles.

src/jobflow_remote/jobs/submit.py Outdated Show resolved Hide resolved
tests/db/cli/test_job.py Show resolved Hide resolved
tests/db/jobs/test_jobcontroller.py Show resolved Hide resolved
tests/integration/test_slurm.py Outdated Show resolved Hide resolved
@gpetretto gpetretto merged commit 00b7f22 into develop Sep 27, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants