-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Check only one runner #150
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #150 +/- ##
===========================================
+ Coverage 72.28% 73.65% +1.37%
===========================================
Files 45 46 +1
Lines 5671 6070 +399
Branches 890 953 +63
===========================================
+ Hits 4099 4471 +372
+ Misses 1260 1252 -8
- Partials 312 347 +35
|
e8a9534
to
e663546
Compare
Hi @gpetretto Still a few things to be done but I think before going on, it would be better to have the expert's eye on this ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some more comments to the latest changes
e7112a7
to
c0d07de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's all good. I did not test myself the functionality though. I would say it might be something to mention in the next release that if people encounter "weird things" when starting/stopping, they should open an issue. What do you think ?
I can't approve my own PR even if it has more become yours ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added last few comments or suggestions.
Added RunnersLockedError.
2be9e45
to
1a1c2e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Can't approve as it was initially my PR. Bit approved 😀
This PR adds info to the auxiliary collection when the runner is started. The idea would be to warn the user that there may be another runner running already, in which case bad things could happen.
Currently just inserts the info when starting the runner and removes it when stopping it.
Still to be done: