Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to JobController and CLI #132

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Small updates to JobController and CLI #132

merged 3 commits into from
Jun 26, 2024

Conversation

gpetretto
Copy link
Contributor

Addressing a few points discusses in issues:

Copy link
Member

@davidwaroquiers davidwaroquiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me! Just one print to be removed and maybe name change for a fixture to make things more clear ? (see comments)

src/jobflow_remote/jobs/runner.py Outdated Show resolved Hide resolved
tests/db/cli/test_flow.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 49.07%. Comparing base (967e7c5) to head (0f438e1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
- Coverage    49.10%   49.07%   -0.04%     
===========================================
  Files           43       43              
  Lines         4940     4950      +10     
  Branches      1037     1039       +2     
===========================================
+ Hits          2426     2429       +3     
- Misses        2273     2280       +7     
  Partials       241      241              
Files Coverage Δ
src/jobflow_remote/jobs/jobcontroller.py 38.75% <60.00%> (+0.17%) ⬆️
src/jobflow_remote/cli/flow.py 23.65% <0.00%> (-1.64%) ⬇️

@gpetretto gpetretto merged commit 79df076 into develop Jun 26, 2024
5 checks passed
@gpetretto gpetretto deleted the gp/minor_updates branch July 19, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants