-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include path if the base url is generated from the request URL. #1602
base: main
Are you sure you want to change the base?
Include path if the base url is generated from the request URL. #1602
Conversation
|
…ath from parsed URL.
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
=======================================
Coverage 91.04% 91.05%
=======================================
Files 74 74
Lines 4578 4583 +5
=======================================
+ Hits 4168 4173 +5
Misses 410 410
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I just noticed that this PR has a lot in common with PR #663 |
This PR fixes a bug in get_base_url.
If the base URL is not specified in the config file, the function get_base_url extracts the base URL from the request URL.
The current function, however, only returns the scheme (e.g. https) and netloc(e.g. www.example.com) part of the base URL.
A base URL may however also contain a root path (e.g. /optimade).
This patch adds the root path to the base URL.