Switch tests to the Rust Frontegg Mock #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
commented
Aug 21, 2024
Comment on lines
30
to
31
| // TODO: Mock services need to be updated to return these values | ||
| // resource.TestCheckResourceAttrSet("materialize_scim_config.scim_config_example", "tenant_id"), |
There was a problem hiding this comment.
As there is no official documentation for the scim endpoints, we reversed engineered the functionality.
In the old mock we used to have a placeholder for this:
Will submit a follow up PR to fix this in the Rust mock service as well
There was a problem hiding this comment.
PR with a fix for this: MaterializeInc/materialize#29149
| // Data source tests | ||
| resource.TestCheckResourceAttrPair("data.materialize_user.user_data", "id", "materialize_user.example_user", "id"), | ||
| resource.TestCheckResourceAttr("data.materialize_user.user_data", "email", email), | ||
| resource.TestCheckResourceAttr("data.materialize_user.user_data", "verified", "false"), | ||
| resource.TestCheckResourceAttr("data.materialize_user.user_data", "verified", "true"), |
There was a problem hiding this comment.
Is this just a change in the mock behavior?
There was a problem hiding this comment.
Yep, we decided to default to true:
RobinClowers
approved these changes
Aug 21, 2024
bobbyiliev
added a commit
to MaterializeInc/materialize
that referenced
this pull request
Aug 21, 2024
Fixing a small bug where the `tenant_id` in the scim configuration should not be expected as payload but be extracted from the access token itself. This was noticed while switching mock service for the Terraform provider tests in here: MaterializeInc/terraform-provider-materialize#634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the #461 epic, now that we have all of the required endpoints transferred over, removing the Frontegg Mock Golang implementation in favour of the Rust Frontegg mock service from the main Materialize repo.