Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS connection empty internal table #630

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

bobbyiliev
Copy link
Contributor

Fixes #629

@bobbyiliev bobbyiliev requested a review from a team as a code owner August 9, 2024 18:49
@bobbyiliev bobbyiliev requested review from SangJunBak and removed request for a team August 9, 2024 18:49
@bobbyiliev bobbyiliev force-pushed the bugfix-aws-connection-empty-internal-table branch from c2762ed to a35459f Compare August 9, 2024 19:23
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah sorry, I forgot about the other --aws arg you had to pass. LGTM!

@bobbyiliev bobbyiliev merged commit 5881b6c into main Aug 9, 2024
4 checks passed
@bobbyiliev bobbyiliev deleted the bugfix-aws-connection-empty-internal-table branch August 9, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: materialize_connection_aws resource read query not detecting all attributes
2 participants