unify cluster alter commands

[jubrad]

Unifying cluster alter commands. This is a pre-req for adding graceful reconfiguration.

[jubrad]

Test this with the following setup:

./terraformrc

provider_installation {
  dev_overrides {
    "MaterializeInc/materialize" = "/Users/justin/go/bin/"
  }
  direct {}
}

terraform {
  required_providers {
    materialize = {
      source = "MaterializeInc/materialize"
    }
  }
}

provider "materialize" {
  password       = "dontlookatmypassworddood"
  default_region = "aws/us-east-1"
  database       = "materialize"
  cloud_endpoint = "https://api.staging.cloud.materialize.com"
  base_endpoint  = "https://admin.staging.cloud.materialize.com"
  endpoint       = "https://admin.staging.cloud.materialize.com"
}

resource "materialize_cluster" "test" {
  name               = "test"
  size               = "25cc"
  replication_factor = 2
}

Then changed the size/replication factor a few ways..
I can see in the sql lifecycle on the console that it ran successfully in a single statement, where using the latest release was multiple statements.

[bobbyiliev]

This looks great! Thanks a lot @jubrad!

The only issue that I've noticed while manually testing this is that if you were to change the scheduling from enabled true to false, it generates the following alter statement which will fail:

ALTER CLUSTER "scheduling_cluster" SET ();

Repro:

resource "materialize_cluster" "scheduling_cluster" {
  name = "scheduling_cluster"
  size = "50cc"
  scheduling {
    on_refresh {
      enabled                 = true # Apply and then change to false and apply again
      hydration_time_estimate = "3 hour"
    }
  }
}

[jubrad]

@bobbyiliev the plan now is that we do AlterClusterScheduling separate from AlterCluster and always first.

This will allow us to from a cluster with scheduling and no replication factor to a cluster without scheduling and a replication factor, and vice versa.

Note, we only really set the scheduling option on the ClusterBuilder directly in the create phase where everything can be done in a single statement.

[bobbyiliev]

I believe that this looks good! Thank you for putting this all together @jubrad 👏