Change C include statements to use " instead of <

[ParkMyCar]

AFAIU using angle brackets for #include statements is generally used for system headers while double-quotes prioritizes headers in the current working directory (stackoverflow). It's compiler dependent, but using double-quotes fixes some issues I ran into while building with clang via Bazel

[benesch]

Probably fine, though a little confused about what Bazel is doing here.

Can you see if you can get CI working here again? I'll feel a little better with a green build. Feel free to just ditch the "ubuntu-old" job.

[ParkMyCar]

Probably fine, though a little confused about what Bazel is doing here.

It's specifically for getting CXX to work with Bazel. I haven't totally tracked it down, but I think it's Bazel's cc_library rule setting the include paths for deps with -iquote instead of just -I.

Can you see if you can get CI working here again? I'll feel a little better with a green build. Feel free to just ditch the "ubuntu-old" job.

For sure! It looks like it has something to do with trying to find SIMD instructions for x86 (not x86_64) architectures. Seems like it's linking against libs from clang 14.0 which is quite old.

[benesch]

I haven't totally tracked it down, but I think it's Bazel's cc_library rule setting the include paths for deps with -iquote instead of just -I.

Ah, well, that would explain it...

[ParkMyCar]

For the build issue, it looks like clang got rig of the __build_ia32_* family of intrinsics (Phabricator) which will cause problems if you try compiling with a newer version of clang without the intrinsics against a version of libclang with the intrinsics.

Adding clang --version to the CI script indicates that when running with the ubuntu 22.04 image we should be using clang-14, but the build still fails. This comment indicates that clang-15 is also available on the system, so my guess it that the cmake crate that protobuf-src uses is invoking the build with clang-15 but linking against the headers from clang-14.

Side stepping all of this, the ubuntu-20.04 image works out of the box, so that's what I set CI to use.

[benesch]

Great, let's roll with this. Thanks for fixing this up, Parker!