adapter,sql: Abbreviate extremely long stack traces, storing full trace in TMPDIR#36971
Open
mgree wants to merge 1 commit into
Open
adapter,sql: Abbreviate extremely long stack traces, storing full trace in TMPDIR#36971mgree wants to merge 1 commit into
mgree wants to merge 1 commit into
Conversation
…saving whole trace in an appropriate temporary directory
def-
reviewed
Jun 11, 2026
def-
left a comment
def-
left a comment
Contributor
There was a problem hiding this comment.
What if you keep storing /tmp files until environmentd runs out of disk? I'd just log the stack trace instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#36888 (comment)
Description
Pre-materializes backtraces, possibly excerpting the head and tail (25 frames/50 lines each). Full traces are saved to an appropriate TMPDIR.
Verification
Manual verification using the given example. (It's possible to write a more complex test to, e.g., ensure that the trace exists and has the right number of lines, but it doesn't feel worth it.)