build(deps): Bump lgalloc to 0.4.0 #30606
Open
+53
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
approved these changes
Nov 23, 2024
antiguru
approved these changes
Nov 23, 2024
def-
force-pushed
the
pr-lgalloc4
branch
2 times, most recently
from
206e4b3
to
4035b31
Compare
antiguru
reviewed
Nov 23, 2024
src/metrics/src/lgalloc.rs
Outdated
| accum.add_assign(file_stat); | ||
| } | ||
| } | ||
| Err(err) => eprintln!("Failed to get file stats: {err}"), |
There was a problem hiding this comment.
We might want to return the error from Update so that on error we stop the task that collects metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://materializeinc.slack.com/archives/C07PN7KSB0T/p1732360387888179
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.