Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-benchmark: Increase scale of fast scenarios, reduce retries #30596

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

def-
Copy link
Contributor

@def- def- commented Nov 22, 2024

For context see https://materializeinc.slack.com/archives/C0761MZ3QD9/p1732280715336919

Successful nightly: https://buildkite.com/materialize/nightly/builds/10501
Release qualification with known regression: https://buildkite.com/materialize/release-qualification/builds/688

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-fb branch 6 times, most recently from f471151 to 64d027d Compare November 22, 2024 22:13
@def- def- requested a review from teskje November 22, 2024 22:14
@def- def- requested a review from a team as a code owner November 23, 2024 07:20
@def- def- requested a review from bobbyiliev November 25, 2024 07:26
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the idea! Not familiar enough with the feature benchmarks to say if this behaves as advertised (in particular I don't see where the number of retries is reduced), but if it passes the Nightlies I assume it must be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that change here intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I find submodules to be very annoying. Will fix.

@def- def- enabled auto-merge November 25, 2024 09:55
@def- def- merged commit fe419bf into MaterializeInc:main Nov 25, 2024
83 of 84 checks passed
@def- def- deleted the pr-fb branch November 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants