give mz_analytics select access to a few more builtin views #29796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
reviewed
Sep 30, 2024
| @@ -3075,7 +3081,7 @@ pub static MZ_STATEMENT_LIFECYCLE_HISTORY: LazyLock<BuiltinSource> = | |||
| // TODO[btv]: Maybe this should be public instead of | |||
| // `MONITOR_REDACTED`, but since that would be a backwards-compatible | |||
| // chagne, we probably don't need to worry about it now. | |||
| access: vec![SUPPORT_SELECT, MONITOR_REDACTED_SELECT, MONITOR_SELECT], | |||
There was a problem hiding this comment.
I'm worried this will drop/recreate the source, and blow away all the data. Worth either double checking locally that this does not happen, or (probably easier) just omitting this one for now.
There was a problem hiding this comment.
(The views are fine because dropping/recreating a view doesn't touch any data on S3.)
There was a problem hiding this comment.
Never mind. @jkosh44 confirmed on Slack that this won't cause the source to be recreated.
doy-materialize
force-pushed
the
doy-analytics-views
branch
from
14d336b
to
dec9fdb
Compare
benesch
approved these changes
Sep 30, 2024
doy-materialize
force-pushed
the
doy-analytics-views
branch
from
dec9fdb
to
43c2777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we want to be able to run internal analytics queries on mz_recent_activity_log_redacted
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.