Teach upgrade checker to use aws-secrets-reader #29792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubrad
force-pushed
the
upgrade-checker-aws-secrets-reader
branch
3 times, most recently
from
804aaa9
to
1541762
Compare
jubrad
force-pushed
the
upgrade-checker-aws-secrets-reader
branch
from
1541762
to
3f78fbf
Compare
jubrad
force-pushed
the
upgrade-checker-aws-secrets-reader
branch
from
3f78fbf
to
912ad78
Compare
benesch
approved these changes
Oct 1, 2024
ParkMyCar
approved these changes
Oct 1, 2024
| @@ -1088,7 +1088,7 @@ impl UnopenedPersistCatalogState { | |||
| .into()); | |||
| } | |||
| ( | |||
| Mode::Writable, | |||
| Mode::Writable | Mode::Savepoint, | |||
There was a problem hiding this comment.
Was it necessary to reintroduce this? Maybe this got pulled in as part of a rebase? Joe removed it very recently 76bdf33
There was a problem hiding this comment.
Ah this was intentional—see #29792 (review)!
There was a problem hiding this comment.
AFAICT, 76bdf33 was a hack to work around passing in the correct deploy generation, as we're setting up to do with this PR.
There was a problem hiding this comment.
Yes, I believe joe introduced this because it broke the upgrade checker... I fixed the upgrade checker :)
jubrad
changed the title
rjobanp
pushed a commit
that referenced
this pull request
Oct 1, 2024
Teach upgrade checker to use aws-secrets-reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.