[persist] ProtoArrayData optimization - part two #29787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ParkMyCar Wanna take the review on this one? |
ParkMyCar
approved these changes
Oct 1, 2024
Comment on lines
+638
to
645
| let Some(mut child) = body.children.pop() else { | ||
| break; | ||
| }; | ||
| let Some(mut field) = fields.pop() else { break }; |
There was a problem hiding this comment.
nit: Not part of this PR so feel free to ignore, but it seems like it would be nice to at least have a soft_assert! here that child and field have the same data type
There was a problem hiding this comment.
Sadly no longer possible, by design - since we only keep type info at the top level, there's no type info on child structs to check.
This reverts commit f8b6fa515041b4671211898602547a1ac09c4527.
bkirwi
force-pushed
the
trim-arraydata-2
branch
from
0590e19
to
cb4b412
Compare
|
Nightly subset was fine - will get this merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part 2 of #29457 - now that all released versions can handle proto with type info only at the top level, write it in the more compact form.
Tips for reviewer
The upgrade tests are important here - I'll get nightlies going.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.