Metrics server#156
Conversation
|
I've temporarily pointed this at the network-policies branch, to make it easier to review the stacked changes. Do not merge without pointing back to main and rebase after the network policies PR is merged. |
| # Required for the Materialize Console to display cluster metrics | ||
| # Disabled by default because AKS provides metrics-server by default | ||
| # TODO: we should rather rely on AKS metrics-server instead of installing our own, confirm with team and get rid of this helm release | ||
| # If you need to install a custom metrics-server, use the kubernetes/modules/metrics-server module: |
There was a problem hiding this comment.
What namespace is the AKS provided metrics-server in? Do we need additional network policies to access it?
There was a problem hiding this comment.
No, for both AKS and GCP metrics-server exists in kube-system ns, for which we already have network policy in place.
|
|
||
| namespace = "monitoring" | ||
| create_namespace = false # operator creates the "monitoring" namespace | ||
| create_namespace = true |
There was a problem hiding this comment.
Have you tested upgrades from previous code to this? Does the operator removing the namespace cause this to be deleted and conflict?
There was a problem hiding this comment.
yes there is a issue during upgrades if you are using existing operator module where monitoring ns is created inside operator, a race condition occurs, the request to create namespace and destroy namespace run simultaneously and I get namespace exists error, it works on the second apply. I didn't bother too much about it assuming there's not customer dependency on this as of now.
jubrad
force-pushed
the
network-policies
branch
from
a26e6ab to
2c2a3b7
Compare
|
Are these changes still needed? If so I will resolve the merge conflicts and have it ready for merge, else I can close it if this is not needed anymore. |
2 participants
Add metrics-server kubernetes module. This should be reviewed after #153
Related Issue: #3