Associations #3
Associations #3
Conversation
There was a problem hiding this comment.
STATUS: REQUIRED CHANGES ♻️
Hi @MasumaJaffery👋🏽,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✅ You used Git Flow correctly 👍🏽
✅ Linter checks passed✔️
✅ Created a class Classroom✔️
✅ Created a class Book✔️
✅ Created a class Rental✔️
✅ Created the has-many/belongs-to relationship between Classroom and Student✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
book.rb
Outdated
| def initialize(title, author) | ||
| @title = title | ||
| @author = author | ||
| @eental = [] |
There was a problem hiding this comment.
- I've noticed a discrepancy in your code in this section. It should reference
rentalrather thaneental😀. Please make the necessary corrections.👍
person.rb
Outdated
|
|
||
| class Person < Nameable | ||
| # Accessors Methods That used for getters and Setters in quick way! | ||
| # Accessors Methods That used for getters and Setters in a quick way! | ||
| # attr_accessor works for getter and setter both purposes. | ||
| attr_accessor :name, :age |
There was a problem hiding this comment.
- Great job on your implementation! However, I noticed that you missed including the
:rentalsattribute in the attr_accessor line. To rectify this, please update the attr_accessor line to include:rentals. This will ensure that you have proper access to the:rentalsattribute in your Person class.👍
student.rb
Outdated
| require_relative 'person' | ||
| # We implement Ineritance Concept here that's about subclass inherits superclass (methods and properties) | ||
| class Student < Person | ||
| # Accessors | ||
| attr_accessor :classroom | ||
|
|
There was a problem hiding this comment.
- It appears that you haven't included the
attr_reader :classroom.I recommend adding it to your code.This aims to ensure that theclassroomattribute has a reader method, enabling external access to its value.👍
There was a problem hiding this comment.
Hi @MasumaJaffery ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉 🎉 🎉
Highlights
✔️ Implemented the changes requested to fix errors in the book, person and student class
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Code Reviewer!
Hope you are doing Great!
In this Milestone;
Thanks for your Time to review my PR!
Happy Reviewing 🤓
Stay Blessed ⭐