Skip to content

Small code maintainability changes #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny-gallagher merged 3 commits into from
Mar 19, 2025
Merged

Small code maintainability changes #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfc194b
Update StringUtils.java
fyf4067 Mar 9, 2025
8b9329c
Update FieldLevelEncryptionConfigBuilderTest.java
fyf4067 Mar 9, 2025
4c95bfd
Update JweConfigBuilderTest.java
fyf4067 Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/mastercard/developer/utils/StringUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ private StringUtils() {
}

public static boolean isNullOrEmpty(String str) {
return null == str || str.length() == 0;
return null == str || str.isEmpty();
}
}
}
4 changes: 2 additions & 2 deletions src/test/java/com/mastercard/developer/encryption/FieldLevelEncryptionConfigBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void testBuild_Nominal_iv12() throws Exception {
Assert.assertEquals("oaepPaddingDigestAlgorithm", config.oaepPaddingDigestAlgorithmFieldName);
Assert.assertEquals("x-oaep-padding-digest-algorithm", config.oaepPaddingDigestAlgorithmHeaderName);
Assert.assertEquals(HEX, config.fieldValueEncoding);
assertThat(config.getIVSize().intValue(),equalTo(12));
assertThat(config.getIVSize(),equalTo(12));
}

@Test
Expand Down Expand Up @@ -107,7 +107,7 @@ public void testBuild_Nominal_iv16() throws Exception {
Assert.assertEquals("oaepPaddingDigestAlgorithm", config.oaepPaddingDigestAlgorithmFieldName);
Assert.assertEquals("x-oaep-padding-digest-algorithm", config.oaepPaddingDigestAlgorithmHeaderName);
Assert.assertEquals(HEX, config.fieldValueEncoding);
assertThat(config.getIVSize().intValue(),equalTo(16));
assertThat(config.getIVSize(),equalTo(16));
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/mastercard/developer/encryption/JweConfigBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void testBuild_Nominal_iv12() throws Exception {
Assert.assertEquals("encryptedPayload", config.getEncryptedValueFieldName());
Assert.assertEquals(Collections.singletonMap("$.encryptedPayload", "$"), config.getDecryptionPaths());
Assert.assertEquals(Collections.singletonMap("$", "$"), config.getEncryptionPaths());
assertThat(config.getIVSize().intValue(),equalTo(12));
assertThat(config.getIVSize(),equalTo(12));
}

@Test
Expand All @@ -54,7 +54,7 @@ public void testBuild_Nominal_iv16() throws Exception {
Assert.assertEquals("encryptedPayload", config.getEncryptedValueFieldName());
Assert.assertEquals(Collections.singletonMap("$.encryptedPayload", "$"), config.getDecryptionPaths());
Assert.assertEquals(Collections.singletonMap("$", "$"), config.getEncryptionPaths());
assertThat(config.getIVSize().intValue(),equalTo(16));
assertThat(config.getIVSize(),equalTo(16));
}

@Test
Expand Down
Loading