Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot assign to read only property 'exports' (issue #335) #337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MelvinSnijders
Copy link

@MelvinSnijders MelvinSnijders commented May 31, 2022

Description

Removed export keyword from the useToast() method.

Related Issue

#335

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MelvinSnijders MelvinSnijders changed the base branch from next to main May 31, 2022 08:46
@dancing-bear-blues
Copy link

I have been up and running for the last few days with this fix in place and do not have any side effects to report. I would like to see this change merged.

dannyjalbert added a commit to dannyjalbert/vue-toastification that referenced this pull request Jun 3, 2022
@lukaszarpak
Copy link

lukaszarpak commented Dec 22, 2022

I found a solution.

Create your own composable and then use it the same way as described in the docs. Just make sure that vue-toastification/nuxt is added to modules in nuxt.config.js so it's injected into useContext().app.


Add these:

./nuxt.config.js

modules: [
	'vue-toastification/nuxt',
]

./composables/useToast

import { useContext } from '@nuxtjs/composition-api'

export const useToast = () => useContext().app.$toast

Usage:

import { useToast } from '@/composables/useToast'

// in setup()
const toast = useToast()

// use toast the same way as described in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants